Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marketing copy #3146

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

marketing copy #3146

wants to merge 2 commits into from
+53 −40

Conversation

scwambach
Copy link
Collaborator

resolves NJWE-2526, NJWE-2527, and NJWE-2528

What I did:

  • edited the copy in the banners
  • Dev Review
  • Design Review

@scwambach
marketing copy
1db180a 
resolves NJWE-2526, NJWE-2527, and NJWE-2528
ChelseaKR
ChelseaKR requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@ChelseaKR ChelseaKR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the Spanish i18n strings? Otherwise LGTM

mflymfly
mflymfly reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@mflymfly mflymfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off on pushing this until DoL gets back to us with updated copy per my notes. We can check in on this with Jewel today to see if there is a plan for that copy to be ready.

@ChelseaKR ChelseaKR marked this pull request as draft January 9, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflymfly mflymfly mflymfly left review comments

@ChelseaKR ChelseaKR ChelseaKR requested changes

@denish-fearless denish-fearless Awaiting requested review from denish-fearless

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scwambach @ChelseaKR @mflymfly